jryans created this revision.
jryans added a reviewer: JDevlieghere.
Herald added a subscriber: ekilmer.
Herald added a project: All.
jryans added a project: LLDB.
jryans published this revision for review.
Herald added a subscriber: lldb-commits.
The `LLDB_LINKER_SUPPORTS_GROUPS` CMake variable was added back in 2019 as part
of https://reviews.llvm.org/D71306, but it appears to have been unused even
then. This removes the unused variable.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D156997
Files:
lldb/cmake/modules/LLDBConfig.cmake
Index: lldb/cmake/modules/LLDBConfig.cmake
===================================================================
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -17,12 +17,6 @@
"`CMakeFiles'. Please delete them.")
endif()
-set(LLDB_LINKER_SUPPORTS_GROUPS OFF)
-if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT "${CMAKE_SYSTEM_NAME}" MATCHES
"Darwin")
- # The Darwin linker doesn't understand --start-group/--end-group.
- set(LLDB_LINKER_SUPPORTS_GROUPS ON)
-endif()
-
macro(add_optional_dependency variable description package found)
cmake_parse_arguments(ARG
"QUIET"
Index: lldb/cmake/modules/LLDBConfig.cmake
===================================================================
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -17,12 +17,6 @@
"`CMakeFiles'. Please delete them.")
endif()
-set(LLDB_LINKER_SUPPORTS_GROUPS OFF)
-if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT "${CMAKE_SYSTEM_NAME}" MATCHES "Darwin")
- # The Darwin linker doesn't understand --start-group/--end-group.
- set(LLDB_LINKER_SUPPORTS_GROUPS ON)
-endif()
-
macro(add_optional_dependency variable description package found)
cmake_parse_arguments(ARG
"QUIET"
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
