bulbazord added inline comments.
================
Comment at: lldb/examples/python/symbolication.py:413-418
name = os.path.basename(self.path)
+ if not name:
+ if self.uuid == uuid.UUID(int=0):
+ return None
+ else:
+ return "error: invalid image path with valid UUID (%s)
" % uuid_str
----------------
It looks like `name` is only used below on line 435 to create `obj_file`, so
you could move that computation down there and check the validity of
`self.path` instead. Does that work? Or am I missing something?
Also, it seems like you might want to do this chunk of work at the beginning of
the function to make sure you have a valid image before you try to process it?
Is there an edge case where we'd still want to process a module with a UUID of
0 and no path?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157137/new/
https://reviews.llvm.org/D157137
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
