This revision was automatically updated to reflect the committed changes. Closed by commit rG23312cde45b9: [lldb] Remove {Get,Set}CloseInputOnEOF and deprecate SB equivalent (NFC) (authored by JDevlieghere). Herald added a project: LLDB.
Changed prior to commit: https://reviews.llvm.org/D158000?vs=550383&id=550388#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158000/new/ https://reviews.llvm.org/D158000 Files: lldb/include/lldb/Core/Debugger.h lldb/source/API/SBDebugger.cpp lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp =================================================================== --- lldb/source/Core/Debugger.cpp +++ lldb/source/Core/Debugger.cpp @@ -929,15 +929,6 @@ }); } -bool Debugger::GetCloseInputOnEOF() const { - // return m_input_comm.GetCloseOnEOF(); - return false; -} - -void Debugger::SetCloseInputOnEOF(bool b) { - // m_input_comm.SetCloseOnEOF(b); -} - bool Debugger::GetAsyncExecution() { return !m_command_interpreter_up->GetSynchronous(); } Index: lldb/source/API/SBDebugger.cpp =================================================================== --- lldb/source/API/SBDebugger.cpp +++ lldb/source/API/SBDebugger.cpp @@ -1535,17 +1535,16 @@ return false; } +LLDB_DEPRECATED("SBDebugger::GetCloseInputOnEOF() is deprecated.") bool SBDebugger::GetCloseInputOnEOF() const { LLDB_INSTRUMENT_VA(this); - return (m_opaque_sp ? m_opaque_sp->GetCloseInputOnEOF() : false); + return false; } +LLDB_DEPRECATED("SBDebugger::SetCloseInputOnEOF() is deprecated.") void SBDebugger::SetCloseInputOnEOF(bool b) { LLDB_INSTRUMENT_VA(this, b); - - if (m_opaque_sp) - m_opaque_sp->SetCloseInputOnEOF(b); } SBTypeCategory SBDebugger::GetCategory(const char *category_name) { Index: lldb/include/lldb/Core/Debugger.h =================================================================== --- lldb/include/lldb/Core/Debugger.h +++ lldb/include/lldb/Core/Debugger.h @@ -241,10 +241,6 @@ void ClearIOHandlers(); - bool GetCloseInputOnEOF() const; - - void SetCloseInputOnEOF(bool b); - bool EnableLog(llvm::StringRef channel, llvm::ArrayRef<const char *> categories, llvm::StringRef log_file, uint32_t log_options,
Index: lldb/source/Core/Debugger.cpp =================================================================== --- lldb/source/Core/Debugger.cpp +++ lldb/source/Core/Debugger.cpp @@ -929,15 +929,6 @@ }); } -bool Debugger::GetCloseInputOnEOF() const { - // return m_input_comm.GetCloseOnEOF(); - return false; -} - -void Debugger::SetCloseInputOnEOF(bool b) { - // m_input_comm.SetCloseOnEOF(b); -} - bool Debugger::GetAsyncExecution() { return !m_command_interpreter_up->GetSynchronous(); } Index: lldb/source/API/SBDebugger.cpp =================================================================== --- lldb/source/API/SBDebugger.cpp +++ lldb/source/API/SBDebugger.cpp @@ -1535,17 +1535,16 @@ return false; } +LLDB_DEPRECATED("SBDebugger::GetCloseInputOnEOF() is deprecated.") bool SBDebugger::GetCloseInputOnEOF() const { LLDB_INSTRUMENT_VA(this); - return (m_opaque_sp ? m_opaque_sp->GetCloseInputOnEOF() : false); + return false; } +LLDB_DEPRECATED("SBDebugger::SetCloseInputOnEOF() is deprecated.") void SBDebugger::SetCloseInputOnEOF(bool b) { LLDB_INSTRUMENT_VA(this, b); - - if (m_opaque_sp) - m_opaque_sp->SetCloseInputOnEOF(b); } SBTypeCategory SBDebugger::GetCategory(const char *category_name) { Index: lldb/include/lldb/Core/Debugger.h =================================================================== --- lldb/include/lldb/Core/Debugger.h +++ lldb/include/lldb/Core/Debugger.h @@ -241,10 +241,6 @@ void ClearIOHandlers(); - bool GetCloseInputOnEOF() const; - - void SetCloseInputOnEOF(bool b); - bool EnableLog(llvm::StringRef channel, llvm::ArrayRef<const char *> categories, llvm::StringRef log_file, uint32_t log_options,
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits