bulbazord added inline comments.
================
Comment at: lldb/include/lldb/Core/Module.h:126
Module(
- const FileSpec &file_spec, const ArchSpec &arch,
- const ConstString *object_name = nullptr,
+ const FileSpec &file_spec, const ArchSpec &arch, ConstString object_name,
lldb::offset_t object_offset = 0,
----------------
fdeazeve wrote:
> Out of curiosity, what was the rationale for removing the default parameter
> here?
I didn't really even think about it, I probably should have just done
`ConstString object_name = ConstString()` or something.
================
Comment at:
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:806
+ target.GetArchitecture(),
+ ConstString());
}
----------------
mib wrote:
> Can this be `{}` ?
Yes, although I'll probably make the default value of the parameter be an empty
ConstString instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158043/new/
https://reviews.llvm.org/D158043
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
