bulbazord added a comment.

Re-organizing the paths seems okay to me, especially since this is going to 
grow further. I think the header guards are going to need some adjustment 
though.



================
Comment at: 
lldb/include/lldb/Interpreter/Interfaces/ScriptedProcessInterface.h:9
 
-#ifndef LLDB_INTERPRETER_SCRIPTEDPROCESSINTERFACE_H
-#define LLDB_INTERPRETER_SCRIPTEDPROCESSINTERFACE_H
+#ifndef LLDB_INTERPRETER_SCRIPTED_PROCESS_INTERFACE_H
+#define LLDB_INTERPRETER_SCRIPTED_PROCESS_INTERFACE_H
----------------
I think the LLVM convention is to reserve underscores for the `/` in the file 
path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158833/new/

https://reviews.llvm.org/D158833

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to