kastiglione added a comment. Thanks for doing this!
Question to all: Should the summary string include the unit? lldb doesn't always show the type, so it could help comprehension if the unit is included. For example `60s` instead of `60`. ================ Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:986-993 + "^std::__[[:alnum:]]+::chrono::" + "(((nano)|(micro)|(milli)|())seconds)|" + "(minutes)|" + "(hours)|" + "(days)|" + "(weeks)|" + "(months)|" ---------------- there's some regex grouping that doesn't seem to be needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/new/ https://reviews.llvm.org/D159127 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits