clayborg wrote: I still think we should have a "lldb_private" namespace for generic code that uses the internal virtual plug-in APIs. It would be nice to have the "lldb_plugins" namespace for plugins and the DWARF plug-in would go into "lldb_plugins::dwarf". Right now if we export "lldb_private::*", we are going to get a lot more functions exported if poeple used to export "lldb_private::*", so this will case a change in behavior. If someone needs the DWARF plug-in, they can add "lldb_plugins::dwarf" to the exports list. We might also keep exporting more and more functions as time goes on if people follow the current state of this PR where you add your plugin into the lldb_private namespace if they see the DWARF plug-in now doing it, so they might copy it. This doesn't really affect me as I never plan to use the fragile API, I am just trying to point this out in case it makes sense.
https://github.com/llvm/llvm-project/pull/68150 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
