junior-jl wrote: > Opinions differ on what goes in a commit message but this seems fine to me, > I'd just remove the sub-headings. My usual rule is that folks can choose not > to read it if they don't want to, include as much information as you would > want to see if you yourself had to come back to fix this change. > (which happens to me more than I'd like to admit :) )
That's a good rule, thanks! Removed the sub-headings. > (if you don't have the permissions to do that, I can do it for you, let me > know when you're ready) I don't have write permissions here. Also, I tried using the `--fixup` flag on the second commit, does that mean the squashing is automatic or I need to squash the commits and push again? https://github.com/llvm/llvm-project/pull/73173 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
