walter-erquinigo wrote:

> Also, I noticed some error messages were different for some tests — I'm 
> guessing they may have changed in newer versions of libipt.

That makes sense. In this case I'd just drop text comparisons for those tests. 
Just knowing that an error was found is good enough.

> FAIL: testStartPerCpuSession 
> (TestTraceStartStopMultipleThreads.TestTraceStartStopMultipleThreads)   

Leave that test failing. I'm pretty that your changes haven't affected this 
test, so it's been broken for a while. Just ignore it for now :) We can fix it 
later if that's something that prevents you from doing your actual work.

https://github.com/llvm/llvm-project/pull/77252
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to