dwblaikie wrote:

> > Thanks for the fix! I did test this patch with both our regression issue, 
> > and also allowing us to remove the double-lookup working around #53904 and 
> > can confirm it addressed both issues. Thanks again!
> 
> Glad it worked! It will also be a huge improvement in the expression parser 
> and avoid these weird expression parser bugs where it doesn't work sometimes 
> and does other times, so it was totally worth fixing. I am also glad to know 
> that the type lookups are being so much more efficient. Having a repro case 
> is always the best way to help us fix bugs, so thanks for posting the details 
> so we can repro easily.

Turns out it actually got worse, see 
https://github.com/llvm/llvm-project/issues/79668 - now whether or not a given 
nested type is accessible via name lookup depends on which copy of the outer 
type is loaded first & there's no workaround that I know of - the lookup then 
fails/succeeds permanently.

Be good to get this addressed - as now it's not possible to lookup these nested 
members at all reliably (even the "repeat the lookup" workaround doesn't work - 
maybe there are other workarounds? But none that I can think of)

https://github.com/llvm/llvm-project/pull/77029
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to