jimingham wrote: > > I will aim to land this sometime tomorrow if there are no further objections > > Per the documentation ( > https://llvm.org/docs/CodeReview.html#code-review-workflow ), please don't do > this. Once it's sent for review, please wait for approval (ping as needed, > etc) before landing.
Felipe already had Adrian's approval, and so far as I can see there were no outstanding comments he hadn't addressed. Surely in that case, you don't have to wait for all the other people selected as reviewers to weigh in do you? That would be pretty unworkable, lots of people assigned as reviewers don't... Seems to me since this PR already had an approval and no No's, Felipe could have committed it right away. Holding on for late reviewers seems like a courtesy, not a violation of the "you must have an approval" policy. https://github.com/llvm/llvm-project/pull/79932 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
