================
@@ -82,20 +94,37 @@ ProgressManager &ProgressManager::Instance() {
return *g_progress_manager;
}
-void ProgressManager::Increment(std::string title) {
+void ProgressManager::Increment(Progress::ProgressData progress_data) {
----------------
JDevlieghere wrote:
This should take a const ref to avoid the copy `const Progress::ProgressData&
progress_data`. If we'd unconditionally store it in the map I'd say the copy is
fine as you'd be able to move it into the map, but I'm assuming most of the
time we're only using the title to do the lookup.
https://github.com/llvm/llvm-project/pull/83069
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
