https://github.com/aabhinavg created https://github.com/llvm/llvm-project/pull/91882
This commit addresses issue #87244, where a redundant condition was found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the Target.cpp file fix #87244 >From 9b4160975efe059f39a842689b1f750a10453203 Mon Sep 17 00:00:00 2001 From: aabhinavg <tiwariabhina...@gmail.com> Date: Sun, 12 May 2024 12:42:59 +0530 Subject: [PATCH] Fix redundant condition in Target.cpp This commit addresses issue #87244, where a redundant condition was found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the Target.cpp file --- lldb/source/Target/Target.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp index 82f3040e539a3..fe87728a33dc8 100644 --- a/lldb/source/Target/Target.cpp +++ b/lldb/source/Target/Target.cpp @@ -841,12 +841,14 @@ static bool CheckIfWatchpointsSupported(Target *target, Status &error) { if (!num_supported_hardware_watchpoints) return true; - if (num_supported_hardware_watchpoints == 0) { - error.SetErrorStringWithFormat( - "Target supports (%u) hardware watchpoint slots.\n", - *num_supported_hardware_watchpoints); - return false; - } + // If num_supported_hardware_watchpoints is zero, set an + //error message and return false. + + error.SetErrorStringWithFormat( + "Target supports (%u) hardware watchpoint slots.\n", + *num_supported_hardware_watchpoints); + return false; + return true; } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits