https://github.com/labath requested changes to this pull request.

FWIW, I think this feature would be more useful and easier to implement if 
there was just a single setting called "connection url" or something, which 
accepted all of the usual lldb connection urls (unix-abstract-connect://, 
listen://, ...).

Since a simple tcp port connection is definitely going to be the most commonly 
used connection, you can, if you want, treat a simple number (or `:number`) as 
an alias to `connect://localhost:number`. lldb-server does something similar.

PS: I'm clicking request changes because I don't believe the test for the 
feature can go in in this form. I don't consider myself an owner for the rest, 
so you can consider my comments as suggestions.

https://github.com/llvm/llvm-project/pull/91570
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to