labath wrote:

What I meant was something like 
[this](https://github.com/llvm/llvm-project/pull/106955). Basically, keep the 
socket code inside the socket class, but make it asynchronous. This way you can 
listen for as many sockets (and other things) as you like. It shouldn't be 
necessary to do the socket handling stuff externally.

I haven't looked into exactly how this would fit into the Acceptor class in 
lldb-server, but my preferred solutions would be:
- delete it (or at least significantly slim down it's functionality -- it's a 
very thin wrapper over the Socket class, and probably only exists due to 
historic reasons)
- make it callback-based as well

I don't like the idea of making Acceptor responsible for multiple ports for the 
same reason I did not want to do that for TCPSocket -- it's complicated and 
inflexible.

https://github.com/llvm/llvm-project/pull/104238
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to