https://github.com/jeffreytan81 requested changes to this pull request.

The logic makes sense.

Implementation wise, instead of calling `builder.DeleteFile()` in every failure 
code path, I would suggest creating a RAII class which calls 
`builder.DeleteFile()` in destructor. Then you just need to create a single 
RAII object in this method and without catching every single exit point. This 
will greatly simplify the code. 

https://github.com/llvm/llvm-project/pull/108259
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to