chris, thanks for the pointer. there are some other sites where the solution i gave to greg will have to be replaced. i will certainly look into it for this.
++ kirk On 2011-Feb-6, at 10:00 AM, ext [email protected]<mailto:[email protected]> wrote: ---------------------------------------------------------------------- Message: 1 Date: Sun, 6 Feb 2011 05:56:27 -0800 From: Chris Lattner <[email protected]<mailto:[email protected]>> Subject: Re: [Lldb-commits] [lldb] r124889 - in /lldb/trunk/source: Plugins/Disassembler/llvm/DisassemblerLLVM.cpp Plugins/Process/MacOSX-User/source/ProcessMacOSXLog.cpp Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp lldb-log.cpp To: Greg Clayton <[email protected]<mailto:[email protected]>> Cc: [email protected]<mailto:[email protected]> Message-ID: <[email protected]<mailto:[email protected]>> Content-Type: text/plain; charset=us-ascii On Feb 4, 2011, at 10:55 AM, Greg Clayton wrote: Author: gclayton Date: Fri Feb 4 12:55:41 2011 New Revision: 124889 URL: http://llvm.org/viewvc/llvm-project?rev=124889&view=rev Log: Patch to remove uses of non-standard strcasestr and replace then with strncasecmp equivalents from Kirk Beitz. FWIW, I strongly recommend using StringRef for this sort of code. It has methods like compare_lower which are portable, and also efficient. For case sensitive stuff, LLVM has a StringSwitch template which works well and is also efficient. -Chris ++ kirk beitz : nokia : austin + san diego : [email protected]<mailto:[email protected]> ++
_______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
