Looks good for FreeBSD. Viktor, thanks for the patch and Filipe for the commit.
As an observation, the ProcessMonitor code for FreeBSD and Linux should probably be looked at for alignment since FreeBSD is using fd/fork and Linux is using the lldb PseudoTerminal interface. Mark On 5/31/12 12:51 AM, Filipe Cabecinhas wrote: > Sending source/Plugins/Process/FreeBSD/ProcessMonitor.cpp > Transmitting file data . > Committed revision 157735. > > > Thanks, > > Filipe > > > On Thursday, May 31, 2012 at 8:34 AM, Greg Clayton wrote: > >> This is a FreeBSD only patch, I will let anyone involved with FreeBSD >> comment. >> >> On May 30, 2012, at 3:32 PM, Viktor Kutuzov wrote: >> >>> Hi everyone, >>> >>> Please find attached patch, which fixes a console hang on the freebsd >>> systems. This hang always occurs on a repeated launch of the process. >>> The following steps will reproduce the problem: >>> >>> (lldb) target create /bin/hostname >>> Current executable set to '/bin/hostname' (x86_64). >>> (lldb) proc launch >>> Process 41002 launched: '/bin/hostname' (x86_64) >>> ... >>> (lldb) proc kill >>> Process 41002 exited with status = -1 (0xffffffff) >>> * thread #1: tid = 0xa02a, , stop reason = trace >>> frame #0: >>> >>> (lldb) proc launch >>> Process 41003 launched: '/bin/hostname' (x86_64) >>> ... >>> (lldb) ...<hang>... >>> >>> Would somebody review and apply this patch? >>> >>> Thanks. >>> Viktor.<lldb-freebsd-processmonitor-console-hang.patch>_______________________________________________ >>> lldb-dev mailing list >>> [email protected] (mailto:[email protected]) >>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev >> >> >> >> _______________________________________________ >> lldb-dev mailing list >> [email protected] (mailto:[email protected]) >> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev > > > > _______________________________________________ > lldb-dev mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev > _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
