Greg, Thanks for quick review. I will rename the struct now. Regards, Abid
> -----Original Message----- > From: Greg Clayton [mailto:[email protected]] > Sent: 24 March 2014 17:14 > To: Abid, Hafiz > Cc: [email protected] > Subject: Re: [lldb-dev] [patch] > > I would rename the structure rather than undefining a macro that could > cause other errors. > > On Mar 24, 2014, at 5:26 AM, Abid, Hafiz <[email protected]> wrote: > > > Hi All, > > It seems that gcc defines i386 when we are not building with -std=c++11. > This was causing me a build error as some new types were added in the code > with name i386. So this patch #undefs i386. There is a better alternate > available if someone needs this macro. > > http://gcc.gnu.org/onlinedocs/gcc-4.3.5/cpp/System_002dspecific- > Predefined-Macros.html > > > > Please note that LLVM is compiled with -std=gnu++11 for mingw since > commit 3f06e3f55fb2f2a3ec03903a53633bf270575599. OK? > > > > Regards, > > Abid > > <i386.patch>_______________________________________________ > > lldb-dev mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
