On 18 April 2014 13:32, Todd Fiala <[email protected]> wrote: > > Linux tests should be green again. > > I had one test I had to mark xfail for the moment. Hopefully Ed's or Luke's > patch in progress will address the underlying issue - a breakpoint is showing > up as hit twice when it should be once according to the test. It's quite > possibly fallout from the fix to stop the tests from hanging. But I'll take > an xfail over a hang.
My change will probably be FreeBSD-specific -- the thread handling is the one aspect in which the FreeBSD and Linux implementations differ significantly. In the case of llvm.org/pr19347, the second thread encounters a breakpoint after the first thread is in kernel, handling its breakpoint. On FreeBSD all threads are stopped by the time we return from waitpid(), although only the first thread's SIGTRAP is delivered. It is possible, although not efficient, to determine that the 2nd thread has encountered a breakpoint or other signal as well. My plan is to just loop over waitpid() calls for this case, draining (and delivering) all waiting signals. As far as I can tell, on Linux the Debugger must explicitly stop the other threads, so the handling of other pending signals will be a bit trickier. _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
