My first attempts to suppress failed. I will revisit later. For now, I reverted: tfiala-macbookpro:lldb tfiala$ svn commit Sending lldb.xcodeproj/project.pbxproj Sending lldb.xcodeproj/xcshareddata/xcschemes/LLDB.xcscheme Sending lldb.xcodeproj/xcshareddata/xcschemes/Run Testsuite.xcscheme Sending lldb.xcodeproj/xcshareddata/xcschemes/darwin-debug.xcscheme Sending lldb.xcodeproj/xcshareddata/xcschemes/launcherRootXPCService.xcscheme Sending lldb.xcodeproj/xcshareddata/xcschemes/launcherXPCService.xcscheme Sending lldb.xcodeproj/xcshareddata/xcschemes/lldb-tool.xcscheme Sending test/tools/lldb-gdbserver/lldbgdbserverutils.py Sending tools/debugserver/debugserver.xcodeproj/project.pbxproj Sending tools/debugserver/debugserver.xcodeproj/xcshareddata/xcschemes/debugserver.xcscheme Transmitting file data .......... Committed revision 209151.
On Mon, May 19, 2014 at 11:05 AM, Todd Fiala <[email protected]> wrote: > Oh yeah I see it. Fixing it up. > > > On Mon, May 19, 2014 at 11:02 AM, Todd Fiala <[email protected]> wrote: > >> > If you can revert the 32/64 but truncation warnings, please do. >> >> Ok - will do. If I can't figure out how to isolate and fix that, I'll >> just revert the whole thing. Thanks! >> >> >> On Mon, May 19, 2014 at 10:53 AM, Greg Clayton <[email protected]>wrote: >> >>> I believe this is something the project updating changed. If you can >>> revert the 32/64 but truncation warnings, please do. >>> >>> > On May 19, 2014, at 10:30 AM, Todd Fiala <[email protected]> wrote: >>> > >>> > Hmm, I'mm seeing some warnings on the debugserver Xcode build that >>> make it look like it may have just switched from a 32-bit build to a 64-bit >>> build on the "lldb-tool | My Mac 64-bit" scheme. >>> > >>> > For example, I'm seeing what I think are new warnings where system >>> calls are returning 64 bits but they're placed in uint32_t and the like, >>> and warning about losing integer precision. >>> > >>> > I might have just been ignoring those before, though, and not realized >>> it. Any thoughts, Greg? I will revert the change (or tweak if that's >>> simple) based on whatever you need me to do here. >>> > >>> > FWIW the debugserver gdb-remote protocol tests I have in TOT are all >>> working fine. >>> > >>> > Sample warnings follow (might be that -Wshorten-64-to-32 was added as >>> part of the settings upgrade - so these may have always been there, just >>> not noisy). >>> > >>> > ===== >>> > In file included from >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:31: >>> > >>> > >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/DNBDataRef.h:61:47: >>> warning: implicit conversion loses integer precision: 'size_t' (aka >>> 'unsigned long') to 'const offset_t' (aka 'const unsigned int') >>> [-Wshorten-64-to-32] >>> > >>> > const offset_t size = GetSize(); >>> > >>> > ~~~~ ^~~~~~~~~ >>> > >>> > In file included from >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:34: >>> > >>> > /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/DNBTimer.h:89:29: >>> warning: implicit conversion loses integer precision: 'const >>> __darwin_time_t' (aka 'const long') to 'uint32_t' (aka 'unsigned int') >>> [-Wshorten-64-to-32] >>> > >>> > sec = m_timeval.tv_sec; >>> > >>> > ~ ~~~~~~~~~~^~~~~~ >>> > >>> > In file included from >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:35: >>> > >>> > In file included from >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.h:21: >>> > >>> > >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachException.h:80:24: >>> warning: implicit conversion loses integer precision: 'const value_type' >>> (aka 'const long long') to 'int' [-Wshorten-64-to-32] >>> > >>> > return exc_data[1]; >>> > >>> > ~~~~~~ ^~~~~~~~~~~ >>> > >>> > >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1489:34: >>> warning: implicit conversion loses integer precision: 'ssize_t' (aka >>> 'long') to 'int' [-Wshorten-64-to-32] >>> > >>> > bytes_read = ::read (stdout_fd, s, sizeof(s)-1); >>> > >>> > ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> > >>> > >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1513:34: >>> warning: implicit conversion loses integer precision: 'ssize_t' (aka >>> 'long') to 'int' [-Wshorten-64-to-32] >>> > >>> > bytes_read = ::read (stderr_fd, s, sizeof(s)-1); >>> > >>> > ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> > >>> > >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1603:16: >>> warning: implicit conversion loses integer precision: 'uint64_t' (aka >>> 'unsigned long long') to 'useconds_t' (aka 'unsigned int') >>> [-Wshorten-64-to-32] >>> > >>> > usleep(proc->ProfileInterval()); >>> > >>> > ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~ >>> > >>> > >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:2266:24: >>> warning: implicit conversion loses integer precision: 'size_t' (aka >>> 'unsigned long') to 'u_int' (aka 'unsigned int') [-Wshorten-64-to-32] >>> > >>> > if (::sysctl (mib, len, &cpu, &cpu_len, 0, 0)) >>> > >>> > ~~ ^~~ >>> > >>> > >>> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:42:20: >>> warning: unused function 'CopyBundleIDForPath' [-Wunused-function] >>> > >>> > static CFStringRef CopyBundleIDForPath (const char *app_bundle_path, >>> DNBError &err_str); >>> > >>> > ^ >>> > >>> > >>> > >>> > >>> > >>> > >>> > -Todd >>> > >>> > >>> > On Mon, May 19, 2014 at 10:06 AM, Todd Fiala <[email protected]> >>> wrote: >>> > Done: >>> > >>> > tfiala-macbookpro:lldb tfiala$ svn commit >>> > Sending lldb.xcodeproj/project.pbxproj >>> > Sending lldb.xcodeproj/xcshareddata/xcschemes/LLDB.xcscheme >>> > Sending lldb.xcodeproj/xcshareddata/xcschemes/Run >>> Testsuite.xcscheme >>> > Sending >>> lldb.xcodeproj/xcshareddata/xcschemes/darwin-debug.xcscheme >>> > Sending >>> lldb.xcodeproj/xcshareddata/xcschemes/launcherRootXPCService.xcscheme >>> > Sending >>> lldb.xcodeproj/xcshareddata/xcschemes/launcherXPCService.xcscheme >>> > Sending lldb.xcodeproj/xcshareddata/xcschemes/lldb-tool.xcscheme >>> > Sending tools/debugserver/debugserver.xcodeproj/project.pbxproj >>> > Sending >>> >>> tools/debugserver/debugserver.xcodeproj/xcshareddata/xcschemes/debugserver.xcscheme >>> > Transmitting file data ......... >>> > Committed revision 209142. >>> > >>> > >>> > On Mon, May 19, 2014 at 9:50 AM, Todd Fiala <[email protected]> >>> wrote: >>> > Okay, will do, thanks! >>> > >>> > >>> > On Mon, May 19, 2014 at 9:38 AM, Greg Clayton <[email protected]> >>> wrote: >>> > Please, feel free to update the settings and check them in. >>> > >>> > > On May 18, 2014, at 8:31 PM, Todd Fiala <[email protected]> >>> wrote: >>> > > >>> > > Hey guys, >>> > > >>> > > I consistently get a couple warnings on lldb.xcodeproj and >>> debugserver.xcodeproj about "Update to recommended settings". Is there any >>> reason why we couldn't run that upgrade and check it in? (Some kind of >>> backwards compatibility we need to maintain?)\ >>> > > >>> > > Thanks! >>> > > >>> > > -- >>> > > -Todd >>> > >>> > >>> > >>> > >>> > -- >>> > -Todd >>> > >>> > >>> > >>> > -- >>> > -Todd >>> > >>> > >>> > >>> > -- >>> > -Todd >>> >>> >> >> >> -- >> -Todd >> > > > > -- > -Todd > -- -Todd
_______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
