Hi Mathew, I had a quick look and nothing jumped at me. Although I think you are missing call to PlatformKalimba::Terminate().
Regards, Abid > -----Original Message----- > From: lldb-dev-boun...@cs.uiuc.edu [mailto:lldb-dev-boun...@cs.uiuc.edu] > On Behalf Of Matthew Gardiner > Sent: 14 July 2014 11:55 > To: lldb-dev@cs.uiuc.edu > Subject: [lldb-dev] [PATCH] The kalimba Platform plugin > > Hi people, > > As some of you are already aware I have been working towards a lldb port > which debugs CSRs Kalimba chips. I have recently added a PlatformKalimba > plugin. With some slight tweaking to the .note parsing section of the > ObjectFileELF and a few Makefiles, my lldb build now lists "kalimba" as an > available Platform and associates any kalimba binary Targets with this > Platform. > > Now I do not currently have submit access for lldb (though we are planning > on adding lldb buildbots and running the testsuites soon, so perhaps this > situation will change in the future), so I've built a patch which comprises > this > work. The impact of the patch on the rest of lldb is minimal, and since I am > not running the testsuites yet, I have spent some time testing my build > against a linux binary, and can claim that all the basic run, paused, step, > backtrace, inspect variables commands still work. Indeed the platform > commands continue to work as expected for the host linux platform. > > So I'd appreciate if anyone could cast their eyes over this patch and see if > it > looks ok to submit or if it is missing anything. I've based the > PlatformKalimba > on PlatformLinux and basically stripped out anything which I don't think is > immediately applicable. I've also removed any copied comments, since for > the most part they are historic, and in order to try to keep the source > reasonably self-documenting. I'll also add that the platform is deliberately > incomplete, and will be fleshed subsequently. I hope I made no CMake > mistakes, I have little experience with CMake, and so my CMakeLists.txt files > are all based on copying from other CMakeLists.txts. > > Anyway, > I look forward to your feedback. > > thanks > Matthew Gardiner > > > Member of the CSR plc group of companies. CSR plc registered in England > and Wales, registered number 4187346, registered office Churchill House, > Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United > Kingdom More information can be found at www.csr.com. Keep up to date > with CSR on our technical blog, www.csr.com/blog, CSR people blog, > www.csr.com/people, YouTube, www.youtube.com/user/CSRplc, Facebook, > www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at > www.twitter.com/CSR_plc. > New for 2014, you can now access the wide range of products powered by > aptX at www.aptx.com. _______________________________________________ lldb-dev mailing list lldb-dev@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
