Deepak, Sure. Actually I also have a few other fixes. But I will hold on to them for now.
Thanks, Abid > -----Original Message----- > From: Deepak Panickal [mailto:[email protected]] > Sent: 07 August 2014 18:30 > To: Abid, Hafiz; [email protected] > Subject: Re: [Patch] break-insert command in lldb-mi > > Hi Abid, > > I actually had a bunch of fixes and new features to upstream for lldb-mi, > which I plan to do tomorrow. > Could you please hold off committing this patch till then? > > Thanks, > Deepak > > On 07/08/2014 18:19, Abid, Hafiz wrote: > > Hi Deepak, > > I was testing lldb-mi and I found a few issues with the break-insert > command. > > > > 1. The constructor of CMICmdArgValString used in this command did not > provide an option to set m_bHandleDirPaths. So the parsing will fail on > command like "26-break-insert --thread-group i1 -f > /home/abidh/demos/main.c:22". I added another parameter to the > constructor to solve this issue. > > > > 2. The parameter -f does not take any argument. The code was thinking > that it takes one which was causing an error. > > > > After these changes the break-insert command is working fine for me. > Please let me know if you see any problem with these change. Otherwise I > will apply them. > > > > Thanks, > > Abid _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
