Looks good. We can tweak it in the future if required if this ever fails.

> On Aug 22, 2014, at 4:57 AM, Matthew Gardiner <m...@csr.com> wrote:
> 
> Hi Greg,
> 
> I've modified the DWARF parsing accordingly. See:
> 
> http://reviews.llvm.org/D5022
> 
> 
> if you're happy with this, I'll  submit on tuesday. It resulted in no 
> regressions when I ran the python tests on linux.
> 
> Matt
> 
> 
> Greg Clayton wrote:
>> On Aug 21, 2014, at 4:23 AM, Matthew Gardiner <m...@csr.com> wrote:
>>> Apologies for me getting noisy on this thread.
>>> 
>>> However, I don't think it's possible to work around toolchains that adopt 
>>> the DWARF2/3 suggested form. The problem occurs if lldb wants to support 
>>> debugging ELFs produced on different hosts - i.e. if the producer and 
>>> consumers of the DWARF are either POSIX/Windows. We could then have a 
>>> situation where a comp_dir string is something like:
>>> 
>>> c:/home/source
>> Actually I think you will be ok because it will be:
>> 
>> c:\home\source  for windows...
>> 
>>> in this case, we cannot determine whether c is a drive-letter or a hostname.
>>> 
>>> (So, I think we'll be changing our toolchain accordingly :-)
>>> 
>>> However, if anyone has any opinions on this DWARF2/3 debate I'd be 
>>> interested in hearing them.
>> Feel free to modify the DWARF parser to strip off the leading hostname to 
>> get things fixed and working. If it is part of the older _or_ current spec, 
>> we should support it in LLDB.
>> 
>> Greg
>> 
>> 
>>  To report this email as spam click 
>> https://www.mailcontrol.com/sr/MZbqvYs5QwJvpeaetUwhCQ== .
> 
> 
> 
> Member of the CSR plc group of companies. CSR plc registered in England and 
> Wales, registered number 4187346, registered office Churchill House, 
> Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
> More information can be found at www.csr.com. Keep up to date with CSR on our 
> technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people, 
> YouTube, www.youtube.com/user/CSRplc, Facebook, 
> www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at 
> www.twitter.com/CSR_plc.
> New for 2014, you can now access the wide range of products powered by aptX 
> at www.aptx.com.

_______________________________________________
lldb-dev mailing list
lldb-dev@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev

Reply via email to