That is one option. Phabricator (http://reviews.llvm.org) provides a convenient way to give people access to a grpahical diff, and include reviewers. The usual workflow is to create a diff in Phabricator, attach the patch to it, and set one of the subscribers to lldb-commits. This will automatically send email to the list.
Either is fine. On Mon, Dec 1, 2014 at 7:02 AM, Andy Chien <ach...@blueshiftinc.com> wrote: > I haven't really done this before. Now that I have a fix attached to the > bug and verified what is the next step to get it upstream'd? Do I send the > patch to lldb-commit? > > On Tue, Nov 25, 2014 at 12:41 PM, İsmail Dönmez <ism...@donmez.ws> wrote: > >> Reported as http://llvm.org/bugs/show_bug.cgi?id=21670 >> >> On Tue, Nov 25, 2014 at 7:53 PM, Zachary Turner <ztur...@google.com> >> wrote: >> >>> Can you file a bug at http://llvm.org/bugs/ and Cc the author of the >>> patch? >>> >>> >>> On Tue Nov 25 2014 at 9:49:43 AM İsmail Dönmez <ism...@donmez.ws> wrote: >>> >>>> AFAIK this is broken by r221570 but sadly I don't have time to debug >>>> this. >>>> >>>> On Tue, Nov 25, 2014 at 7:12 PM, Zachary Turner <ztur...@google.com> >>>> wrote: >>>> >>>>> If you want to dig in and try to figure out why it's not working >>>>> right, patches would be welcome. >>>>> >>>>> >>>>> On Tue Nov 25 2014 at 8:36:13 AM İsmail Dönmez <ism...@donmez.ws> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> On Tue, Nov 25, 2014 at 5:52 PM, Zachary Turner <ztur...@google.com> >>>>>> wrote: >>>>>> >>>>>>> Looks to me like its not linking llvmsupport.a. Not sure why though. >>>>>>> Can you try removing >>>>>>> >>>>>>> -DBUILD_SHARED_LIBS=ON \ >>>>>>> -DCMAKE_BUILD_TYPE=RelWithDebInfo \ >>>>>>> >>>>>>> >>>>>> This fixes the problem so looks like shared libs build is now broken. >>>>>> >>>>>> Thanks. >>>>>> >>>>>> >>>> >> >> _______________________________________________ >> lldb-dev mailing list >> lldb-dev@cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev >> >> >
_______________________________________________ lldb-dev mailing list lldb-dev@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
