We should probably have a stack that we can push and pop these states? > On Sep 28, 2017, at 10:59 AM, Leonard Mosescu via lldb-dev > <lldb-dev@lists.llvm.org> wrote: > > Thank you Jim! I'm at cppcon and I won't be able to work on it until Monday, > but I can help with a code review if you're planning to take a stab at it. > > I was hoping we can avoid dealing with reentrancy but I was wrong. For > handling reentrancy I was briefly considering either maintaining a full blown > command stack or perhaps just a nesting counter. > > Also, with reentrancy, I think that interruption should affect the "outmost" > command scope rather than just interrupting the current command, what do you > think? > > > > > On Wed, Sep 27, 2017 at 6:46 PM, Jim Ingham via lldb-dev > <lldb-dev@lists.llvm.org <mailto:lldb-dev@lists.llvm.org>> wrote: > This actually asserts on any use "command source" is the one command that > re-enters the command interpreter. It should be as simple as getting command > source to rest the state flag before it goes to do the sourcing. I'll check > that out tomorrow if nobody gets to it first. > > command source is one of a set of early commands that we got into lldb before > we had hired the person who wrote the testsuite way way back in the day, and > though we went and backfilled the tests at that point, apparently we missed > command source. So we'll also have to add a test for that. > > I also filed: > > https://bugs.llvm.org/show_bug.cgi?id=34758 > <https://bugs.llvm.org/show_bug.cgi?id=34758> > > to cover the issue. > > Jim > > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org <mailto:lldb-dev@lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev> > > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
