I have been playing around with the latest version of LTK-Java and have a couple of suggestions:
1) Building - I had trouble using the ant script to build the jar. The jar seemed to only contain the manifest file. However, the class files were still there, so I could use those. 2)Log4J configuring. The log4j currently prints out a warning whenever there is a "missing" optional param. However when I've omitted an optional param, I usually meant to. I wouldn't mind them, except that there are alot of them sometimes. It would be nice if I could turn off warnings that have to do with omitting optional params. This may just be me not knowing how to use log4j though. 3)Some specs that have lists inside have an 'addListItem(ListItemType)' method in them. For example, With ROSpec, I can do something like this: ROSpec rs = new ROSpec(); AISpec ais = createAISpec(); rs.addSpecParameter(ais); This is really nice. However, some specs don't have this, such as the aispec with its list of antenna IDS. In that case, I have to do this: UnsignedShortArray usa = new UnsignedShortArray(1); usa.set(0, new UnsignedShort(0)); ais.setAntennaIDs(usa); I find that hard to use because as a java list user, I am used to not having to supply initial values for lists, and am prone to make this mistake: UnsignedShortArray usa = new UnsignedShortArray(); which will create a array of size 0, and throw an indexOutOfBounds exception when I try to put something in it. It would be nice if all I had to do was this: ais.addAntennaID(new UnsignedShort(0)); 4) Along the same lines, if there is a addListElement() method, why not have a getListElementAt(int index) and a getSizeOfList() method for each list in the specs too? Having these methods end up saving the programmer using the toolkit quite a few lines of code. 5) I noticed that the log4j output was giving me some warnings that wern't quite true. When building a rospec, I got these warnings: -ROSpec misses non optional parameter of type ROReportSpec -AISpecStopTrigger misses non optional parameter of type GPITriggerValue -AISpecStopTrigger misses non optional parameter of type TagObservationTrigger -ROSpecStopTrigger misses non optional parameter of type GPITriggerValue -ROSpecStartTrigger misses non optional parameter of type GPITriggerValue - ROSpecStartTrigger misses non optional parameter of type PeriodicTriggerValue These params, however, are optional. I posted a couple of bugs on the bug tracker on ltk sourceforge page that were more serious things. Overall, I really like this code, and its coming along nicely. -Kyle ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ llrp-toolkit-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel
