#1. Yes. #2. Great idea for just removing else condition. Thanks!
Xiaoyong -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Matt Moeller Sent: Monday, December 03, 2007 12:36 PM To: 'LLRP Toolkit Development List' Subject: Re: [ltk-d] [LTKNET] LLRPClient bugs and a patch For #1: 1. I think you meant "cI.OnMessageReceived -= ProcesssMessage" to "cI.OnMessageReceived -= new delegateMessageReceived(ProcesssMessage)". If that's the case, sounds great. 2. Great idea. For #2: My intention was not to remove the entire else{..} block, only the else condition. The current logic will not fire an event when a READER_EVENT_NOTIFICATION message is received with a valid ConnectionAttemptEvent parameter. Here's what I had in mind: if (conn_evt != null && ntf.__ReaderEventNotificationData.__ConnectionAttemptEvent != null) { conn_status_type = ntf.__ReaderEventNotificationData.__ConnectionAttemptEvent.__Status; conn_evt.Set(); } // always fire the event // else // { delegateReaderEventNotification rEvent = new delegateReaderEventNotification(TriggerReaderEventNotification); rEvent.BeginInvoke(ntf, null, null); // } -Matt -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Xiaoyong Su Sent: Monday, December 03, 2007 2:10 PM To: LLRP Toolkit Development List Subject: Re: [ltk-d] [LTKNET] LLRPClient bugs and a patch Hello Matt and All, Thank for your input on the LLRP .NET toolkit. Regarding the two patches. #1 patch: 1. I would like to change "cI.OnClientConnected -= ProcessMessage" to "cI.OnClientConnected -= new delegateClientConnected(ProcesssMessage)" in Close() method; 2. Set initial status to status = ENUM_ConnectionAttemptStatusType.Failed_Reason_Other_Than_A_Connection_A lready_Exists; #2 patch: removing the "...else{...}" part is not correct. Doing this way will lead to result that no reader event notification will be send to client. Regards, Xiaoyong -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Matt Moeller Sent: Monday, December 03, 2007 11:26 AM To: [email protected] Subject: [ltk-d] [LTKNET] LLRPClient bugs and a patch Hello all, I believe I've fixed a couple bugs in the .NET toolkit's LLRPClient class and I thought I'd attach a patch with my changes to see what everyone else thinks. All comments welcome. Thanks, -Matt ------------------------------------------------------------------------ - SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ llrp-toolkit-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel ------------------------------------------------------------------------ - SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ llrp-toolkit-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ llrp-toolkit-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel
