Author: Michał Górny Date: 2020-12-07T09:56:51+01:00 New Revision: 1a1cc0ba7db549025ab1a504633ae4554042fd60
URL: https://github.com/llvm/llvm-project/commit/1a1cc0ba7db549025ab1a504633ae4554042fd60 DIFF: https://github.com/llvm/llvm-project/commit/1a1cc0ba7db549025ab1a504633ae4554042fd60.diff LOG: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching Force gdb-remote plugin when attaching using the derivatives of PlatformPOSIX class. This is consistent with the behavior for launching processes (via DebugProcess() method) and guarantees consistent plugin choice on FreeBSD. Differential Revision: https://reviews.llvm.org/D92667 Added: Modified: lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp lldb/test/API/commands/process/attach-resume/TestAttachResume.py lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py Removed: ################################################################################ diff --git a/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp b/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp index f717eaa2b47d..cad5a803ec2e 100644 --- a/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp +++ b/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp @@ -388,8 +388,7 @@ lldb::ProcessSP PlatformPOSIX::Attach(ProcessAttachInfo &attach_info, process_sp = target->CreateProcess(attach_info.GetListenerForProcess(debugger), - attach_info.GetProcessPluginName(), nullptr, - false); + "gdb-remote", nullptr, true); if (process_sp) { ListenerSP listener_sp = attach_info.GetHijackListener(); diff --git a/lldb/test/API/commands/process/attach-resume/TestAttachResume.py b/lldb/test/API/commands/process/attach-resume/TestAttachResume.py index ff1bb8c6921d..a73b6566c747 100644 --- a/lldb/test/API/commands/process/attach-resume/TestAttachResume.py +++ b/lldb/test/API/commands/process/attach-resume/TestAttachResume.py @@ -18,7 +18,6 @@ class AttachResumeTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True @skipIfRemote - @expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr19310') @expectedFailureNetBSD @skipIfWindows # llvm.org/pr24778, llvm.org/pr21753 @skipIfReproducer # FIXME: Unexpected packet during (active) replay diff --git a/lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py b/lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py index 10edae860ed4..51681d65d210 100644 --- a/lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py +++ b/lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py @@ -19,7 +19,6 @@ class TestDeletedExecutable(TestBase): @expectedFailureAll(oslist=["linux"], triple=no_match('aarch64-.*-android')) # determining the architecture of the process fails - @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48374") @skipIfReproducer # File synchronization is not supported during replay. def test(self): self.build() _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
