AaronBallman wrote: > > LGTM, though it would be nice if @petrhosek or @Ericson2314 could validate > > the cmake changes (they look sensible to me, but I never know if there's a > > better way to do things in CMake). > > We already did that above. Petr left a comment and it was fixed :p
Ah, I missed that entirely because the conversations were resolved. Phew, then yeah, LGTM! https://github.com/llvm/llvm-project/pull/86080 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits