ahmedbougacha wrote: > One more overall style comment which might probably require an additional PR: > sometimes identifiers use `PtrAuth`, sometimes `Ptrauth`. Is this > intentional? If not, I suggest to use the same case style - it would keep > things consistent and allow for case-sensitive search.
Yeah, it's hard to avoid needing case-insensitive search because of the irreconcilable capitalization rules between e.g., enums generated from all-lowercase tablegen, opcode namespaces with a strong all-uppercase tradition, variable/function naming conventions, etc. In general I try to standardize on "ptrauth" regardless of case, and would rather get rid of "pauth" or "pac" first, because they're just objectively worse names. We can indeed pick a consistent ptrauth when the dust settles. https://github.com/llvm/llvm-project/pull/85736 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
