https://github.com/kovdan01 requested changes to this pull request.

The changes themself in terms of functionality look OK to me - but I want 
someone else with deeper understanding of the context to take a look before 
this gets merged.

In terms of style, here are some of the categories of minor issues:
- unneeded includes
- wrong case for variables (need `PascalCase`, the surrounding code also uses 
that, so no need for not following the global convention 
https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)
- missing `const` qualifiers and `auto` -> `auto *`


https://github.com/llvm/llvm-project/pull/93904
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to