Author: Serge Pavlov Date: 2024-06-05T10:58:52+07:00 New Revision: 2e96a199a72cdc88e140d0b4dc2a73d32bad762d
URL: https://github.com/llvm/llvm-project/commit/2e96a199a72cdc88e140d0b4dc2a73d32bad762d DIFF: https://github.com/llvm/llvm-project/commit/2e96a199a72cdc88e140d0b4dc2a73d32bad762d.diff LOG: Revert "[symbolizer] Empty string is not an error (#92660)" This reverts commit 22a7f7c3314328dd1ac20042158f4b68a4ac5c1f. Added: Modified: llvm/test/tools/llvm-symbolizer/get-input-file.test llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp Removed: ################################################################################ diff --git a/llvm/test/tools/llvm-symbolizer/get-input-file.test b/llvm/test/tools/llvm-symbolizer/get-input-file.test index 50eb051968718..8c21816591c81 100644 --- a/llvm/test/tools/llvm-symbolizer/get-input-file.test +++ b/llvm/test/tools/llvm-symbolizer/get-input-file.test @@ -1,9 +1,9 @@ # If binary input file is not specified, llvm-symbolizer assumes it is the first # item in the command. -# No input items at all. Report an unknown line, but do not produce any output on stderr. +# No input items at all, complain about missing input file. RUN: echo | llvm-symbolizer 2>%t.1.err | FileCheck %s --check-prefix=NOSOURCE -RUN: FileCheck --input-file=%t.1.err --implicit-check-not={{.}} --allow-empty %s +RUN: FileCheck --input-file=%t.1.err --check-prefix=NOFILE %s # Only one input item, complain about missing addresses. RUN: llvm-symbolizer "foo" 2>%t.2.err | FileCheck %s --check-prefix=NOSOURCE @@ -32,6 +32,8 @@ RUN: FileCheck --input-file=%t.7.err --check-prefix=BAD-QUOTE %s NOSOURCE: ?? NOSOURCE-NEXT: ??:0:0 +NOFILE: error: no input filename has been specified + NOADDR: error: 'foo': no module offset has been specified NOTFOUND: error: 'foo': [[MSG]] diff --git a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp index 6d7953f3109a5..b98bdbc388faf 100644 --- a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp +++ b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp @@ -337,14 +337,6 @@ static void symbolizeInput(const opt::InputArgList &Args, object::BuildID BuildID(IncomingBuildID.begin(), IncomingBuildID.end()); uint64_t Offset = 0; StringRef Symbol; - - // An empty input string may be used to check if the process is alive and - // responding to input. Do not emit a message on stderr in this case but - // respond on stdout. - if (InputString.empty()) { - printUnknownLineInfo(ModuleName, Printer); - return; - } if (Error E = parseCommand(Args.getLastArgValue(OPT_obj_EQ), IsAddr2Line, StringRef(InputString), Cmd, ModuleName, BuildID, Symbol, Offset)) { _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
