================ @@ -2030,8 +2030,25 @@ bool Sema::checkConstantPointerAuthKey(Expr *Arg, unsigned &Result) { return false; } +static std::pair<const ValueDecl *, CharUnits> +findConstantBaseAndOffset(Sema &S, Expr *E) { + // Must evaluate as a pointer. + Expr::EvalResult Result; + if (!E->EvaluateAsRValue(Result, S.Context) || !Result.Val.isLValue()) + return std::make_pair(nullptr, CharUnits()); ---------------- kovdan01 wrote:
Feel free to ignore: use of `std::make_pair` is not required in this context, so you can just write the following: ```suggestion return {nullptr, CharUnits()}; ``` Also applies to a couple of usages of `std::make_pair` below. https://github.com/llvm/llvm-project/pull/93904 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits