================
@@ -657,7 +657,7 @@ MCPseudoProbeDecoder::getCallProbeForAddr(uint64_t Address) 
const {
   const auto &Probes = It->second;
 
   const MCDecodedPseudoProbe *CallProbe = nullptr;
-  for (const auto &Probe : Probes) {
----------------
WenleiHe wrote:

Not a big deal, but still I though it's worth clarifying. Generally the purpose 
of splitting a patch isn't to strip things into individual patches as much as 
possible, but to help reviewers: 1) to make sure a patch is manageable in size 
for review; 2) group changes with logical connection/separation 
(components/steps). The other change isn't that big anyways, and evidently 
splitting here actually make it more difficult for reviewers instead of helping 
them.

https://github.com/llvm/llvm-project/pull/102788
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to