https://github.com/zero9178 approved this pull request.

LGTM

Slight nit in the PR description: Initially reading paragraph one and two had 
me confused whether the `ConversionConfig::buildMaterializations` knob and the 
"automatic materilization" as you called it were referring to the same thing or 
not. Maybe merging these two paragraphs would make this clearer.

https://github.com/llvm/llvm-project/pull/104668
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to