atrosinenko wrote:

Thank you for the review!

> As you are adding a new function, it's good time to fix the naming case to 
> `emitToStreamer`

I think renaming `EmitToStreamer` to `emitToStreamer` now may be a bit 
error-prone, as this function overrides the non-virtual 
`AsmPrinter::EmitToStreamer`, so in `AArch64AsmParser` there would be two 
different functions accessible with almost identical names and almost identical 
implementations.

https://github.com/llvm/llvm-project/pull/110107
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to