llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-core Author: Matthias Springer (matthias-springer) <details> <summary>Changes</summary> This commit simplifies the signature of `OperationConverter::finalize`. This function always returns "success", so the return value can be removed. Note: Previously, this function used to return "failure" if a materialization failed to legalize. This is now optional and happening at a later point of time (see `config.buildMaterializations`). Depends on #<!-- -->110414. --- Full diff: https://github.com/llvm/llvm-project/pull/110419.diff 1 Files Affected: - (modified) mlir/lib/Transforms/Utils/DialectConversion.cpp (+3-7) ``````````diff diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp index b5aab2416c3eb9..a5872cd3d30696 100644 --- a/mlir/lib/Transforms/Utils/DialectConversion.cpp +++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp @@ -2340,7 +2340,7 @@ struct OperationConverter { /// This method is called after the conversion process to legalize any /// remaining artifacts and complete the conversion. - LogicalResult finalize(ConversionPatternRewriter &rewriter); + void finalize(ConversionPatternRewriter &rewriter); /// Dialect conversion configuration. ConversionConfig config; @@ -2464,8 +2464,7 @@ LogicalResult OperationConverter::convertOperations(ArrayRef<Operation *> ops) { // Now that all of the operations have been converted, finalize the conversion // process to ensure any lingering conversion artifacts are cleaned up and // legalized. - if (failed(finalize(rewriter))) - return rewriterImpl.undoRewrites(), failure(); + finalize(rewriter); // After a successful conversion, apply rewrites if this is not an analysis // conversion. @@ -2542,8 +2541,7 @@ getReplacedValues(IRRewrite *rewrite) { return {}; } -LogicalResult -OperationConverter::finalize(ConversionPatternRewriter &rewriter) { +void OperationConverter::finalize(ConversionPatternRewriter &rewriter) { ConversionPatternRewriterImpl &rewriterImpl = rewriter.getImpl(); DenseMap<Value, SmallVector<Value>> inverseMapping = rewriterImpl.mapping.getInverse(); @@ -2578,8 +2576,6 @@ OperationConverter::finalize(ConversionPatternRewriter &rewriter) { llvm::erase(inverseMapping[newValue], originalValue); } } - - return success(); } //===----------------------------------------------------------------------===// `````````` </details> https://github.com/llvm/llvm-project/pull/110419 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
