Meinersbur wrote:

> How recent is your latest rebase? They are missing files in this PR.

I did not do a rebase since I started working on this PR, maybe 3 weeks ago. 
With new files added/removed upstream and at the same time reviewers probably 
asking to change the move location, keeping the PR stack current all the time, 
and also ensure that every change is part of the correct PR, is a bit of a 
hassle. I intend to start updating to `main` only after the directional 
discussion of #110217 concluded (which may for instance decide to rename 
`FortranRuntime` to `flang-rt`). I hope this is understandable.

In the past I also often forgot that I should only merge `main` into the first 
patch of the sequence, then iteratively update all other in the sequence. If 
you don't do that GitHub considers the upsteam commits as part of the PR, and 
runs some bots which automatically add a lot of reviewers and subscribers for 
each touched file in the upstream commits. Since then I am careful to rebase 
patch sequences.

https://github.com/llvm/llvm-project/pull/110298
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
  • [... Michael Kruse via llvm-branch-commits
  • [... via llvm-branch-commits
  • [... via llvm-branch-commits
  • [... via llvm-branch-commits
  • [... Tom Eccles via llvm-branch-commits
  • [... Michael Kruse via llvm-branch-commits
  • [... Tom Eccles via llvm-branch-commits
  • [... Peter Klausler via llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Michael Kruse via llvm-branch-commits
  • [... Michael Kruse via llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Peter Klausler via llvm-branch-commits
  • [... Michael Kruse via llvm-branch-commits
  • [... Peter Klausler via llvm-branch-commits

Reply via email to