https://github.com/skatrak commented:
Thank you Andrew for all this work. I went through your PR and I have some comments, the vast majority of which are only nits. Generally, this looks ok to me, though it's a very large and complex patch, so I'm putting a good amount of trust in unit tests and in that you know what you're doing 😅. Not sure if anything can be done here to make it simpler for other people to follow, since you've already introduced a good amount of comments. https://github.com/llvm/llvm-project/pull/113557 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
