================
@@ -1478,34 +1497,12 @@ Value
ConversionPatternRewriterImpl::findOrBuildReplacementValue(
}
Value castValue = buildUnresolvedMaterialization(
MaterializationKind::Source, computeInsertPoint(repl), value.getLoc(),
----------------
zero9178 wrote:
```suggestion
MaterializationKind::Source, computeInsertPoint(value), value.getLoc(),
```
I believe (at least for the current callers of `findOrBuildReplacementValue`)
that this should be sound.
Alternatively, I think an insertion point should be passed as argument as all
callers should have enough context to have a suitable insertion point which
avoids the new `computeInsertionPoint` overload. This would be very desireable
IMO
https://github.com/llvm/llvm-project/pull/116524
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
