Author: Hongtao Yu Date: 2025-02-11T19:10:33-08:00 New Revision: 669d96d801447471ee4cbe7117c6ba7db8023696
URL: https://github.com/llvm/llvm-project/commit/669d96d801447471ee4cbe7117c6ba7db8023696 DIFF: https://github.com/llvm/llvm-project/commit/669d96d801447471ee4cbe7117c6ba7db8023696.diff LOG: Revert "[mlir] Enable LICM for ops with only read side effects in scf.for (#1…" This reverts commit 36d8e7056ef08d0f51e5b1e928274a8ca7dadeb5. Added: Modified: mlir/include/mlir/Dialect/SCF/IR/SCFOps.td mlir/include/mlir/Interfaces/LoopLikeInterface.td mlir/include/mlir/Interfaces/SideEffectInterfaces.h mlir/include/mlir/Transforms/LoopInvariantCodeMotionUtils.h mlir/lib/Dialect/SCF/IR/SCF.cpp mlir/lib/Interfaces/SideEffectInterfaces.cpp mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp mlir/test/Transforms/loop-invariant-code-motion.mlir mlir/test/lib/Dialect/Test/TestOps.td Removed: ################################################################################ diff --git a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td index ac648aca087f3..6f408b3c924de 100644 --- a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td +++ b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td @@ -40,7 +40,7 @@ def SCF_Dialect : Dialect { and then lowered to some final target like LLVM or SPIR-V. }]; - let dependentDialects = ["arith::ArithDialect", "ub::UBDialect"]; + let dependentDialects = ["arith::ArithDialect"]; } // Base class for SCF dialect ops. @@ -138,9 +138,7 @@ def ForOp : SCF_Op<"for", ["getInitsMutable", "getLoopResults", "getRegionIterArgs", "getLoopInductionVars", "getLoopLowerBounds", "getLoopSteps", "getLoopUpperBounds", "getYieldedValuesMutable", - "moveOutOfLoopWithGuard", "promoteIfSingleIteration", "replaceWithAdditionalYields", - "wrapInTripCountCheck", "unwrapTripCountCheck", "yieldTiledValuesAndReplace"]>, AllTypesMatch<["lowerBound", "upperBound", "step"]>, ConditionallySpeculatable, diff --git a/mlir/include/mlir/Interfaces/LoopLikeInterface.td b/mlir/include/mlir/Interfaces/LoopLikeInterface.td index c4ff0b485565e..c6bffe347419e 100644 --- a/mlir/include/mlir/Interfaces/LoopLikeInterface.td +++ b/mlir/include/mlir/Interfaces/LoopLikeInterface.td @@ -79,18 +79,6 @@ def LoopLikeOpInterface : OpInterface<"LoopLikeOpInterface"> { /*methodBody=*/"", /*defaultImplementation=*/"op->moveBefore($_op);" >, - InterfaceMethod<[{ - Moves the given loop-invariant operation out of the loop with a - trip-count guard. - }], - /*retTy=*/"void", - /*methodName=*/"moveOutOfLoopWithGuard", - /*args=*/(ins "::mlir::Operation *":$op), - /*methodBody=*/"", - /*defaultImplementation=*/[{ - return; - }] - >, InterfaceMethod<[{ Promotes the loop body to its containing block if the loop is known to have a single iteration. Returns "success" if the promotion was diff --git a/mlir/include/mlir/Interfaces/SideEffectInterfaces.h b/mlir/include/mlir/Interfaces/SideEffectInterfaces.h index f8142567c6060..aef7ec622fe4f 100644 --- a/mlir/include/mlir/Interfaces/SideEffectInterfaces.h +++ b/mlir/include/mlir/Interfaces/SideEffectInterfaces.h @@ -433,10 +433,6 @@ bool wouldOpBeTriviallyDead(Operation *op); /// conditions are satisfied. bool isMemoryEffectFree(Operation *op); -/// Returns true if the given operation is free of memory effects or has only -/// read effect. -bool isMemoryEffectFreeOrOnlyRead(Operation *op); - /// Returns the side effects of an operation. If the operation has /// RecursiveMemoryEffects, include all side effects of child operations. /// diff --git a/mlir/include/mlir/Transforms/LoopInvariantCodeMotionUtils.h b/mlir/include/mlir/Transforms/LoopInvariantCodeMotionUtils.h index 83a70abe0a5ed..3ceef44d799e8 100644 --- a/mlir/include/mlir/Transforms/LoopInvariantCodeMotionUtils.h +++ b/mlir/include/mlir/Transforms/LoopInvariantCodeMotionUtils.h @@ -47,19 +47,16 @@ class Value; /// } /// } /// ``` -/// Users must supply four callbacks. +/// +/// Users must supply three callbacks. /// /// - `isDefinedOutsideRegion` returns true if the given value is invariant with /// respect to the given region. A common implementation might be: /// `value.getParentRegion()->isProperAncestor(region)`. /// - `shouldMoveOutOfRegion` returns true if the provided operation can be -/// moved of the given region, e.g. if it is side-effect free or has only read -/// side effects. -/// - `moveOutOfRegionWithoutGuard` moves the operation out of the given region -/// without a guard. A common implementation might be: -/// `op->moveBefore(region->getParentOp())`. -/// - `moveOutOfRegionWithGuard` moves the operation out of the given region -/// with a guard. +/// moved of the given region, e.g. if it is side-effect free. +/// - `moveOutOfRegion` moves the operation out of the given region. A common +/// implementation might be: `op->moveBefore(region->getParentOp())`. /// /// An operation is moved if all of its operands satisfy /// `isDefinedOutsideRegion` and it satisfies `shouldMoveOutOfRegion`. @@ -69,8 +66,7 @@ size_t moveLoopInvariantCode( ArrayRef<Region *> regions, function_ref<bool(Value, Region *)> isDefinedOutsideRegion, function_ref<bool(Operation *, Region *)> shouldMoveOutOfRegion, - function_ref<void(Operation *)> moveOutOfRegionWithoutGuard, - function_ref<void(Operation *)> moveOutOfRegionWithGuard); + function_ref<void(Operation *, Region *)> moveOutOfRegion); /// Move side-effect free loop invariant code out of a loop-like op using /// methods provided by the interface. diff --git a/mlir/lib/Dialect/SCF/IR/SCF.cpp b/mlir/lib/Dialect/SCF/IR/SCF.cpp index 85729486f63d5..83ae79ce48266 100644 --- a/mlir/lib/Dialect/SCF/IR/SCF.cpp +++ b/mlir/lib/Dialect/SCF/IR/SCF.cpp @@ -15,7 +15,6 @@ #include "mlir/Dialect/MemRef/IR/MemRef.h" #include "mlir/Dialect/SCF/IR/DeviceMappingInterface.h" #include "mlir/Dialect/Tensor/IR/Tensor.h" -#include "mlir/Dialect/UB/IR/UBOps.h" #include "mlir/IR/BuiltinAttributes.h" #include "mlir/IR/IRMapping.h" #include "mlir/IR/Matchers.h" @@ -396,40 +395,6 @@ std::optional<SmallVector<OpFoldResult>> ForOp::getLoopUpperBounds() { std::optional<ResultRange> ForOp::getLoopResults() { return getResults(); } -/// Moves the op out of the loop with a guard that checks if the loop has at -/// least one iteration. -void ForOp::moveOutOfLoopWithGuard(Operation *op) { - IRRewriter rewriter(this->getContext()); - OpBuilder::InsertionGuard insertGuard(rewriter); - rewriter.setInsertionPoint(this->getOperation()); - Location loc = this->getLoc(); - arith::CmpIOp cmpIOp = rewriter.create<arith::CmpIOp>( - loc, arith::CmpIPredicate::ult, this->getLowerBound(), - this->getUpperBound()); - // Create the trip-count check. - scf::YieldOp thenYield; - scf::IfOp ifOp = rewriter.create<scf::IfOp>( - loc, cmpIOp, - [&](OpBuilder &builder, Location loc) { - thenYield = builder.create<scf::YieldOp>(loc, op->getResults()); - }, - [&](OpBuilder &builder, Location loc) { - SmallVector<Value> poisonResults; - poisonResults.reserve(op->getResults().size()); - for (Type type : op->getResults().getTypes()) { - ub::PoisonOp poisonOp = - rewriter.create<ub::PoisonOp>(loc, type, nullptr); - poisonResults.push_back(poisonOp); - } - builder.create<scf::YieldOp>(loc, poisonResults); - }); - for (auto [opResult, ifOpResult] : - llvm::zip_equal(op->getResults(), ifOp->getResults())) - rewriter.replaceAllUsesExcept(opResult, ifOpResult, thenYield); - // Move the op into the then block. - rewriter.moveOpBefore(op, thenYield); -} - /// Promotes the loop body of a forOp to its containing block if the forOp /// it can be determined that the loop has a single iteration. LogicalResult ForOp::promoteIfSingleIteration(RewriterBase &rewriter) { @@ -3429,8 +3394,9 @@ ParseResult scf::WhileOp::parse(OpAsmParser &parser, OperationState &result) { if (functionType.getNumInputs() != operands.size()) { return parser.emitError(typeLoc) - << "expected as many input types as operands " << "(expected " - << operands.size() << " got " << functionType.getNumInputs() << ")"; + << "expected as many input types as operands " + << "(expected " << operands.size() << " got " + << functionType.getNumInputs() << ")"; } // Resolve input operands. diff --git a/mlir/lib/Interfaces/SideEffectInterfaces.cpp b/mlir/lib/Interfaces/SideEffectInterfaces.cpp index 7418bc96815ec..59fd19310cea5 100644 --- a/mlir/lib/Interfaces/SideEffectInterfaces.cpp +++ b/mlir/lib/Interfaces/SideEffectInterfaces.cpp @@ -9,7 +9,6 @@ #include "mlir/Interfaces/SideEffectInterfaces.h" #include "mlir/IR/SymbolTable.h" -#include "llvm/ADT/STLExtras.h" #include "llvm/ADT/SmallPtrSet.h" #include <utility> @@ -371,17 +370,6 @@ mlir::getEffectsRecursively(Operation *rootOp) { return effects; } -bool mlir::isMemoryEffectFreeOrOnlyRead(Operation *op) { - std::optional<SmallVector<MemoryEffects::EffectInstance>> effects = - getEffectsRecursively(op); - if (!effects) - return false; - return llvm::all_of(*effects, - [&](const MemoryEffects::EffectInstance &effect) { - return isa<MemoryEffects::Read>(effect.getEffect()); - }); -} - bool mlir::isSpeculatable(Operation *op) { auto conditionallySpeculatable = dyn_cast<ConditionallySpeculatable>(op); if (!conditionallySpeculatable) diff --git a/mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp b/mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp index 094db01176a28..7460746934a78 100644 --- a/mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp +++ b/mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp @@ -60,18 +60,13 @@ size_t mlir::moveLoopInvariantCode( ArrayRef<Region *> regions, function_ref<bool(Value, Region *)> isDefinedOutsideRegion, function_ref<bool(Operation *, Region *)> shouldMoveOutOfRegion, - function_ref<void(Operation *)> moveOutOfRegionWithoutGuard, - function_ref<void(Operation *)> moveOutOfRegionWithGuard) { + function_ref<void(Operation *, Region *)> moveOutOfRegion) { size_t numMoved = 0; for (Region *region : regions) { LLVM_DEBUG(llvm::dbgs() << "Original loop:\n" << *region->getParentOp() << "\n"); - bool anyOpHoistedWithGuard = false; - bool loopSideEffectFreeOrHasOnlyReadSideEffect = - isMemoryEffectFreeOrOnlyRead(region->getParentOp()); - std::queue<Operation *> worklist; // Add top-level operations in the loop body to the worklist. for (Operation &op : region->getOps()) @@ -89,26 +84,12 @@ size_t mlir::moveLoopInvariantCode( continue; LLVM_DEBUG(llvm::dbgs() << "Checking op: " << *op << "\n"); - if (!shouldMoveOutOfRegion(op, region) || !canBeHoisted(op, definedOutside)) continue; - // Can only hoist pure ops (side-effect free) when there is an op with - // write and/or unknown side effects in the loop. - if (!loopSideEffectFreeOrHasOnlyReadSideEffect && !isMemoryEffectFree(op)) - continue; - bool moveWithoutGuard = !anyOpHoistedWithGuard && isMemoryEffectFree(op); - if (moveWithoutGuard) { - LLVM_DEBUG(llvm::dbgs() << "Moving loop-invariant op: " << *op - << " without guard\n"); - moveOutOfRegionWithoutGuard(op); - } else { - LLVM_DEBUG(llvm::dbgs() - << "Moving loop-invariant op: " << *op << " with guard\n"); - moveOutOfRegionWithGuard(op); - anyOpHoistedWithGuard = true; - } + LLVM_DEBUG(llvm::dbgs() << "Moving loop-invariant op: " << *op << "\n"); + moveOutOfRegion(op, region); ++numMoved; // Since the op has been moved, we need to check its users within the @@ -125,14 +106,13 @@ size_t mlir::moveLoopInvariantCode( size_t mlir::moveLoopInvariantCode(LoopLikeOpInterface loopLike) { return moveLoopInvariantCode( loopLike.getLoopRegions(), - [&](Value value, Region *region) { - return !region->isAncestor(value.getParentRegion()); + [&](Value value, Region *) { + return loopLike.isDefinedOutsideOfLoop(value); }, [&](Operation *op, Region *) { - return isSpeculatable(op) && isMemoryEffectFreeOrOnlyRead(op); + return isMemoryEffectFree(op) && isSpeculatable(op); }, - [&](Operation *op) { loopLike.moveOutOfLoop(op); }, - [&](Operation *op) { loopLike.moveOutOfLoopWithGuard(op); }); + [&](Operation *op, Region *) { loopLike.moveOutOfLoop(op); }); } namespace { diff --git a/mlir/test/Transforms/loop-invariant-code-motion.mlir b/mlir/test/Transforms/loop-invariant-code-motion.mlir index 66a34abca5450..5133c14414c97 100644 --- a/mlir/test/Transforms/loop-invariant-code-motion.mlir +++ b/mlir/test/Transforms/loop-invariant-code-motion.mlir @@ -714,150 +714,6 @@ func.func @test_recursively_speculatable_op_failure(%lb: index, %ub: index, %ste return } -// CHECK-LABEL: test_speculatable_op_with_read_side_effect_success -func.func @test_speculatable_op_with_read_side_effect_success(%lb: index, %ub: index, %step: index) -> i32 { - // CHECK: test.always_speculatable_op - // CHECK-NEXT: %[[CMP:.*]] = arith.cmpi ult, %[[LB:.*]], %[[UB:.*]] : index - // CHECK-NEXT: scf.if %[[CMP]] - // CHECK-NEXT: test.speculatable_op_with_memread - // CHECK: else - // CHECK-NEXT: ub.poison : i32 - // CHECK: scf.for %[[_:.*]] = %[[LB]] to %[[UB]] - // CHECK-NOT: test.always_speculatable_op - // CHECK-NOT: test.speculatable_op_with_memread - %cst_0 = arith.constant 0 : i32 - %cst_42 = arith.constant dense<42> : tensor<64xi32> - %ind_42 = arith.constant 42 : index - %sum_result = scf.for %i = %lb to %ub step %step iter_args(%acc = %cst_0) -> i32 { - %always_speculate = "test.always_speculatable_op"() : () -> i32 - %only_read = "test.speculatable_op_with_memread"(%cst_42, %ind_42) : (tensor<64xi32>, index) -> i32 - %i_cast = arith.index_cast %i: index to i32 - %add = arith.addi %acc, %i_cast : i32 - %sum = arith.addi %add, %only_read : i32 - scf.yield %sum : i32 - } - return %sum_result : i32 -} - -// CHECK-LABEL: test_speculatable_op_with_read_side_effect_multiple_result_success -func.func @test_speculatable_op_with_read_side_effect_multiple_result_success(%lb: index, %ub: index, %step: index) -> i32 { - // CHECK: test.always_speculatable_op - // CHECK-NEXT: %[[CMP:.*]] = arith.cmpi ult, %[[LB:.*]], %[[UB:.*]] : index - // CHECK-NEXT: scf.if %[[CMP]] - // CHECK-NEXT: test.speculatable_op_with_memread - // CHECK: else - // CHECK-NEXT: ub.poison : i32 - // CHECK-NEXT: ub.poison : f32 - // CHECK: scf.for %[[_:.*]] = %[[LB]] to %[[UB]] - // CHECK-NOT: test.always_speculatable_op - // CHECK-NOT: test.speculatable_op_with_memread - %cst_0 = arith.constant 0 : i32 - %cst_42 = arith.constant dense<42> : tensor<64xi32> - %ind_42 = arith.constant 42 : index - %sum_result = scf.for %i = %lb to %ub step %step iter_args(%acc = %cst_0) -> i32 { - %always_speculate = "test.always_speculatable_op"() : () -> i32 - %only_read:2 = "test.speculatable_op_with_memread"(%cst_42, %ind_42) : (tensor<64xi32>, index) -> (i32, f32) - %i_cast = arith.index_cast %i: index to i32 - %add = arith.addi %acc, %i_cast : i32 - %sum = arith.addi %add, %only_read#0 : i32 - scf.yield %sum : i32 - } - return %sum_result : i32 -} - -// CHECK-LABEL: test_speculatable_op_with_read_side_effect_success_with_dependents -func.func @test_speculatable_op_with_read_side_effect_success_with_dependents(%lb: index, %ub: index, %step: index) -> i32 { - // CHECK: %[[ALWAYS:.*]] = "test.always_speculatable_op" - // CHECK-NEXT: %[[CMP0:.*]] = arith.cmpi ult, %[[LB:.*]], %[[UB:.*]] : index - // CHECK-NEXT: %[[IF0:.*]] = scf.if %[[CMP0]] - // CHECK-NEXT: test.speculatable_op_with_memread - // CHECK: else - // CHECK-NEXT: ub.poison : i32 - // CHECK: %[[CMP1:.*]] = arith.cmpi ult, %[[LB]], %[[UB]] : index - // CHECK-NEXT: %[[IF1:.*]] = scf.if %[[CMP1]] - // CHECK-NEXT: arith.addi %[[ALWAYS]], %[[IF0]] - // CHECK: else - // CHECK-NEXT: ub.poison : i32 - // CHECK: %[[CMP2:.*]] = arith.cmpi ult, %[[LB]], %[[UB]] : index - // CHECK-NEXT: %[[IF2:.*]] = scf.if %[[CMP2]] - // CHECK-NEXT: test.speculatable_op_with_memread - // CHECK: else - // CHECK-NEXT: ub.poison : i32 - // CHECK: %[[CMP3:.*]] = arith.cmpi ult, %[[LB]], %[[UB]] : index - // CHECK-NEXT: %{{.*}} = scf.if %[[CMP3]] - // CHECK-NEXT: arith.addi %[[IF1]], %[[IF2]] - // CHECK: else - // CHECK-NEXT: ub.poison : i32 - // CHECK: scf.for %{{.*}} = %[[LB]] to %[[UB]] - // CHECK-NOT: test.always_speculatable_op - // CHECK-NOT: test.speculatable_op_with_memread - %cst_0 = arith.constant 0 : i32 - %cst_42 = arith.constant dense<42> : tensor<64xi32> - %ind_42 = arith.constant 42 : index - %sum_result = scf.for %i = %lb to %ub step %step iter_args(%acc = %cst_0) -> i32 { - %always_speculate = "test.always_speculatable_op"() : () -> i32 - %only_read_0 = "test.speculatable_op_with_memread"(%cst_42, %ind_42) : (tensor<64xi32>, index) -> i32 - %add_0 = arith.addi %always_speculate, %only_read_0 : i32 - %only_read_1 = "test.speculatable_op_with_memread"(%cst_42, %ind_42) : (tensor<64xi32>, index) -> i32 - %add_1 = arith.addi %add_0, %only_read_1 : i32 - %i_cast = arith.index_cast %i: index to i32 - %sum = arith.addi %add_1, %i_cast : i32 - scf.yield %sum : i32 - } - return %sum_result : i32 -} - -// CHECK-LABEL: test_speculatable_op_with_read_side_effect_failure_due_to_write -func.func @test_speculatable_op_with_read_side_effect_failure_due_to_write(%lb: index, %ub: index, %step: index) -> i32 { - // CHECK: test.always_speculatable_op - // CHECK-NEXT: scf.for - // CHECK-NOT: test.always_speculatable_op - // CHECK: test.speculatable_op_with_memread - // CHECK: test.speculatable_op_with_memwrite - %cst_0 = arith.constant 0 : i32 - %cst_42 = arith.constant dense<42> : tensor<64xi32> - %ind_42 = arith.constant 42 : index - %sum_result = scf.for %i = %lb to %ub step %step iter_args(%acc = %cst_0) -> i32 { - %always_speculate = "test.always_speculatable_op"() : () -> i32 - %only_read = "test.speculatable_op_with_memread"(%cst_42, %ind_42) : (tensor<64xi32>, index) -> i32 - %i_cast = arith.index_cast %i: index to i32 - %add = arith.addi %acc, %i_cast : i32 - %sum = arith.addi %add, %only_read : i32 - %write = "test.speculatable_op_with_memwrite"(%cst_42) : (tensor<64xi32>) -> i32 - scf.yield %sum : i32 - } - return %sum_result : i32 -} - -// CHECK-LABEL: test_speculatable_op_with_read_side_effect_failure_due_to_nested_write -func.func @test_speculatable_op_with_read_side_effect_failure_due_to_nested_write(%lb: index, %ub: index, %step: index) -> i32 { - // CHECK: test.always_speculatable_op - // CHECK-NEXT: scf.for - // CHECK-NOT: test.always_speculatable_op - // CHECK: test.speculatable_op_with_memread - // CHECK: scf.for - // CHECK: scf.if - // CHECK: test.speculatable_op_with_memwrite - %cst_0 = arith.constant 0 : i32 - %cst_42 = arith.constant dense<42> : tensor<64xi32> - %ind_42 = arith.constant 42 : index - %sum_result = scf.for %i = %lb to %ub step %step iter_args(%acc = %cst_0) -> i32 { - %always_speculate = "test.always_speculatable_op"() : () -> i32 - %only_read = "test.speculatable_op_with_memread"(%cst_42, %ind_42) : (tensor<64xi32>, index) -> i32 - %i_cast = arith.index_cast %i: index to i32 - %add = arith.addi %acc, %i_cast : i32 - %sum = arith.addi %add, %only_read : i32 - scf.for %j = %lb to %ub step %step { - %eq42 = arith.cmpi eq, %j, %ind_42 : index - scf.if %eq42 { - %always_write = "test.speculatable_op_with_memwrite"(%cst_42) : (tensor<64xi32>) -> i32 - } - } - scf.yield %sum : i32 - } - return %sum_result : i32 -} - // ----- func.func @speculate_tensor_dim_unknown_rank_unknown_dim( diff --git a/mlir/test/lib/Dialect/Test/TestOps.td b/mlir/test/lib/Dialect/Test/TestOps.td index 193b682c034f6..2aa0658ab0e5d 100644 --- a/mlir/test/lib/Dialect/Test/TestOps.td +++ b/mlir/test/lib/Dialect/Test/TestOps.td @@ -2947,50 +2947,6 @@ def RecursivelySpeculatableOp : TEST_Op<"recursively_speculatable_op", [ let regions = (region SizedRegion<1>:$body); } -def SpeculatableOpWithReadSideEffect : TEST_Op<"speculatable_op_with_memread", - [ConditionallySpeculatable, MemoryEffects<[MemRead]>]> { - let description = [{ - Op used to test LICM conditional speculation. This op can always be - speculatively executed and has only memory read effect. - }]; - - let arguments = (ins Variadic<AnyType>:$inputs); - let results = (outs Variadic<AnyType>:$outputs); - - let extraClassDeclaration = [{ - ::mlir::Speculation::Speculatability getSpeculatability(); - }]; - - let extraClassDefinition = [{ - ::mlir::Speculation::Speculatability - SpeculatableOpWithReadSideEffect::getSpeculatability() { - return ::mlir::Speculation::Speculatable; - } - }]; -} - -def SpeculatableOpWithWriteSideEffect : TEST_Op<"speculatable_op_with_memwrite", - [ConditionallySpeculatable, MemoryEffects<[MemWrite]>]> { - let description = [{ - Op used to test LICM conditional speculation. This op can always be - speculatively executed and has only memory read effect. - }]; - - let arguments = (ins Variadic<AnyType>:$inputs); - let results = (outs Variadic<AnyType>:$outputs); - - let extraClassDeclaration = [{ - ::mlir::Speculation::Speculatability getSpeculatability(); - }]; - - let extraClassDefinition = [{ - ::mlir::Speculation::Speculatability - SpeculatableOpWithWriteSideEffect::getSpeculatability() { - return ::mlir::Speculation::Speculatable; - } - }]; -} - //===---------------------------------------------------------------------===// // Test CSE //===---------------------------------------------------------------------===// _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
