================
@@ -12,44 +12,59 @@
 using namespace llvm;
 using namespace llvm::mcdxbc;
 
+void setRewrite(raw_ostream &Stream, uint32_t &Offset) {
----------------
damyanp wrote:

I think these two functions are only used from within this cpp.  Should either 
be marked as static, or in an anonymous namespace, to make that clear.

(I'm not sure what LLVM's preference is between static / anonymous namespace)

https://github.com/llvm/llvm-project/pull/128577
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to