https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/131106
Before the dawn of civilization, instructions were printed in all caps using the raw tablegen pseudo-names. This -NOT check was looking for that, instead of the actual ISA output. Just switch to using generated checks. Also replace a use of undef. >From da8190ed5eb0f798d53907ed7a39320f71814389 Mon Sep 17 00:00:00 2001 From: Matt Arsenault <matthew.arsena...@amd.com> Date: Thu, 13 Mar 2025 16:05:26 +0700 Subject: [PATCH] AMDGPU: Fix broken negative test from ancient times Before the dawn of civilization, instructions were printed in all caps using the raw tablegen pseudo-names. This -NOT check was looking for that, instead of the actual ISA output. Just switch to using generated checks. Also replace a use of undef. --- .../dead-machine-elim-after-dead-lane.ll | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/llvm/test/CodeGen/AMDGPU/dead-machine-elim-after-dead-lane.ll b/llvm/test/CodeGen/AMDGPU/dead-machine-elim-after-dead-lane.ll index 9ce0235fdcb18..d616fecfdc1ff 100644 --- a/llvm/test/CodeGen/AMDGPU/dead-machine-elim-after-dead-lane.ll +++ b/llvm/test/CodeGen/AMDGPU/dead-machine-elim-after-dead-lane.ll @@ -1,12 +1,22 @@ -; RUN: llc -mtriple=amdgcn -verify-machineinstrs %s -o - | FileCheck %s +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; RUN: llc -mtriple=amdgcn -mcpu=tahiti %s -o - | FileCheck %s -; CHECK-LABEL: foo -; CHECK-NOT: BUFFER_LOAD_DWORDX2_OFFSET ; After dead code elimination, that buffer load should be eliminated finally ; after dead lane detection. define amdgpu_kernel void @foo() { +; CHECK-LABEL: foo: +; CHECK: ; %bb.0: ; %entry +; CHECK-NEXT: s_cbranch_execnz .LBB0_2 +; CHECK-NEXT: ; %bb.1: ; %LeafBlock1 +; CHECK-NEXT: .LBB0_2: ; %foo.exit +; CHECK-NEXT: s_mov_b32 s3, 0xf000 +; CHECK-NEXT: s_mov_b32 s2, -1 +; CHECK-NEXT: v_mov_b32_e32 v0, 0 +; CHECK-NEXT: buffer_store_dword v0, off, s[0:3], 0 +; CHECK-NEXT: s_endpgm +; CHECK-NEXT: ; %bb.3: ; %sw.bb10 entry: - switch i8 undef, label %foo.exit [ + switch i8 poison, label %foo.exit [ i8 4, label %sw.bb4 i8 10, label %sw.bb10 ] _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits