https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/134052
Backport 9356091a98c24718572f99b51553838ed664b67a Requested by: @nikic >From 542310684354c41f148b8b74f8d4ab6247d85b62 Mon Sep 17 00:00:00 2001 From: Nikita Popov <npo...@redhat.com> Date: Wed, 2 Apr 2025 16:40:53 +0800 Subject: [PATCH] [GlobalMerge][PPC] Don't merge globals in llvm.metadata section (#131801) The llvm.metadata section is not emitted and has special semantics. We should not merge globals in it, similarly to how we already skip merging of `llvm.xyz` globals. Fixes https://github.com/llvm/llvm-project/issues/131394. (cherry picked from commit 9356091a98c24718572f99b51553838ed664b67a) --- llvm/lib/CodeGen/GlobalMerge.cpp | 3 ++- llvm/test/CodeGen/PowerPC/global-merge-llvm-metadata.ll | 9 +++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 llvm/test/CodeGen/PowerPC/global-merge-llvm-metadata.ll diff --git a/llvm/lib/CodeGen/GlobalMerge.cpp b/llvm/lib/CodeGen/GlobalMerge.cpp index 5993fc939a08a..b4650a4851c3c 100644 --- a/llvm/lib/CodeGen/GlobalMerge.cpp +++ b/llvm/lib/CodeGen/GlobalMerge.cpp @@ -711,7 +711,8 @@ bool GlobalMergeImpl::run(Module &M) { continue; // Ignore all 'special' globals. - if (GV.getName().starts_with("llvm.") || GV.getName().starts_with(".llvm.")) + if (GV.getName().starts_with("llvm.") || + GV.getName().starts_with(".llvm.") || Section == "llvm.metadata") continue; // Ignore all "required" globals: diff --git a/llvm/test/CodeGen/PowerPC/global-merge-llvm-metadata.ll b/llvm/test/CodeGen/PowerPC/global-merge-llvm-metadata.ll new file mode 100644 index 0000000000000..7db092e13afeb --- /dev/null +++ b/llvm/test/CodeGen/PowerPC/global-merge-llvm-metadata.ll @@ -0,0 +1,9 @@ +; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu < %s | FileCheck %s + +@index = global i32 0, align 4 +@.str = private unnamed_addr constant [1 x i8] zeroinitializer, section "llvm.metadata" +@.str.1 = private unnamed_addr constant [7 x i8] c"test.c\00", section "llvm.metadata" +@llvm.global.annotations = appending global [1 x { ptr, ptr, ptr, i32, ptr }] [{ ptr, ptr, ptr, i32, ptr } { ptr @index, ptr @.str, ptr @.str.1, i32 1, ptr null }], section "llvm.metadata" + +; CHECK-NOT: .set +; CHECK-NOT: _MergedGlobals _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
