erichkeane wrote:

> @erichkeane What do you think about merging this PR to the release branch?

I'm on the fence.  It IS a regression that we should fix, and the new version 
is significantly better of an implementation than we already have, but the risk 
of further regression is non-zero (and on the higher end of my comfort zone).  

I'm definitely leaning towards "we should do this", but I'd love if we could 
let it bake in 'main' for more time before doing so (though it IS early in the 
next dot release, right? So we should have time to revert before/if the next 
release happens).

https://github.com/llvm/llvm-project/pull/134194
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to