OCHyams wrote: @SLTozer are you happy with my responses to your inline comments? And a few weeks ago offline we discussed that the slightly not-nfc change to preserve isImplicitCode is probably ok. Are you still happy with that?
@jmorse I used some early-exits in the lambda - does that look ok? I can try to separate some bits out if you'd prefer (I'm currently erring on the side of keeping all the context in one place). I added comments to the function arguments to highlight which integer is which (I prefer this approach rather than introducing more boilerplate for code that won't often be touched, but I'm happy to alter further if needed). Slightly annoyingly this pushes the unittest calls over the column limit... I could shorten "AtomGroup" and "AtomRank" to just "Atom" and "Rank", but "Rank" feels too nebulous? https://github.com/llvm/llvm-project/pull/133480 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
