https://github.com/jmorse approved this pull request.
Github doesn't present your latest inline comments at the end of the "conversation" tab, but it does present them in the middle in a repeated comment section. Silly github. I think we've discussed the subtleties enough, the tl;dr is that it's still an improvement and the copy-versus-move situation is only a hazard for code that doesn't exist. We can rely on future authors testing their code. https://github.com/llvm/llvm-project/pull/133482 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
