================ @@ -50,26 +53,26 @@ class MCSectionGOFF final : public MCSection { friend class MCContext; friend class MCSymbolGOFF; - MCSectionGOFF(StringRef Name, SectionKind K, GOFF::SDAttr SDAttributes, - MCSectionGOFF *Parent) - : MCSection(SV_GOFF, Name, K.isText(), /*IsVirtual=*/false, nullptr), + MCSectionGOFF(StringRef Name, SectionKind K, bool IsVirtual, ---------------- MaskRay wrote:
If it's BSS, call it BSS. Virtual seems a weird naming convention when the initial Mach-O MC code was added. New code doesn't need to endorse the weird naming. https://github.com/llvm/llvm-project/pull/137235 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits