llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) <details> <summary>Changes</summary> This patch makes the new premerge system report failures when the build errors out. We were previously not doing this to not notify people on failures as we were testing out the infra. This works towards making the new premerge system canonical and the deprecation of the old system. A launch announcement on Discourse will accompany this commit. --- Full diff: https://github.com/llvm/llvm-project/pull/139359.diff 1 Files Affected: - (modified) .github/workflows/premerge.yaml (-6) ``````````diff diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml index 74ac80ba1b86f..3d29f220d18a8 100644 --- a/.github/workflows/premerge.yaml +++ b/.github/workflows/premerge.yaml @@ -42,9 +42,6 @@ jobs: # Mark the job as a success even if the step fails so that people do # not get notified while the new premerge pipeline is in an # experimental state. - # TODO(boomanaiden154): Remove this once the pipeline is stable and we - # are ready for people to start recieving notifications. - continue-on-error: true run: | git config --global --add safe.directory '*' @@ -109,9 +106,6 @@ jobs: # Mark the job as a success even if the step fails so that people do # not get notified while the new premerge pipeline is in an # experimental state. - # TODO(boomanaiden154): Remove this once the pipeline is stable and we - # are ready for people to start recieving notifications. - continue-on-error: true if: ${{ steps.vars.outputs.windows-projects != '' }} shell: cmd run: | `````````` </details> https://github.com/llvm/llvm-project/pull/139359 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
